Greptile Summary

This PR resolves CI lint failures by modernizing React usage patterns and fixing code quality issues across the codebase.

Key Changes:

• Migrated 9 icon components from deprecated import * as React and React.FC to plain function components, aligning with Backstage's JSX transform migration
• Refactored nested ternary expressions into IIFE pattern for improved readability in HomePage.tsx and PulseCheckPage.tsx
• Cleaned up unused variables (isNegative, theme) and replaced console.error with comment
• Updated ESLint config to support underscore-prefixed unused function parameters
• Unskipped previously problematic test in App.test.tsx

Considerations:
The unskipped test in App.test.tsx was previously marked as incompatible with newer Backstage versions due to app.createRoot() issues. Verify this test passes consistently in CI to ensure it doesn't introduce flakiness.

Confidence Score: 4/5

• This PR is safe to merge with low risk after verifying test stability
• The changes are mechanical lint fixes following established patterns. React import removals align with Backstage best practices. Nested ternary refactoring improves readability. The main concern is the unskipped test which was previously marked problematic - this needs verification in CI to ensure it doesn't cause flakiness.
• packages/app/src/App.test.tsx requires attention - verify test passes consistently after unskipping

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CI as CI Pipeline
    participant ESLint as ESLint
    participant Icons as Icon Components
    participant Pages as Page Components
    
    Dev->>CI: Push changes (before PR)
    CI->>ESLint: Run lint check
    ESLint->>Icons: Check icon files
    Icons-->>ESLint: Error: deprecated React imports
    ESLint->>Pages: Check page files
    Pages-->>ESLint: Error: nested ternaries
    Pages-->>ESLint: Error: unused variables
    ESLint-->>CI: Lint failed ❌
    CI-->>Dev: CI failed
    
    Dev->>Icons: Remove React imports, React.FC
    Dev->>Pages: Refactor ternaries to IIFE
    Dev->>Pages: Remove unused variables
    Dev->>ESLint: Update config (argsIgnorePattern)
    
    Dev->>CI: Push fixes (this PR)
    CI->>ESLint: Run lint check
    ESLint->>Icons: Validate plain function components
    Icons-->>ESLint: Pass ✓
    ESLint->>Pages: Validate IIFE pattern
    Pages-->>ESLint: Pass ✓
    ESLint-->>CI: All checks passed ✓
    CI-->>Dev: CI succeeded